Not to brag but I just merged this. Felt so good.
That’s worth bragging about
package-lock.json?Deleted the test suite since it was failing
Those are rookie numbers
Tell me you commit your dependencies without telling me you commit your dependencies.
Looks good. Approve
Make sure to send all the code minified to make it small and easier to review.
Minified?
Tell me you’re not a web developer without telling me you’re not a web developer
Because my company works on archaic infrastructure, should PRs be as small as possible with sub-issues sorted into smaller PRs?
Small PR are easy to review and parse. Work gets broken down in to small, shippable changes. If you couple that with feature flags, you can get to a point where shipping a release is as easy as building whatever the latest commit is on Main and pushing it out the door.
Automate that, do it every week or two.
I err on the side of splitting because of what Scratch just said. If I give my colleague 2k lines to review it’ll get slapped with a LGTM and passed. If I send them 100 lines they’ll actually look at it.
